Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PyTorch dependency and use it for item-item k-NN #373

Merged
merged 21 commits into from
May 7, 2024
Merged

Add PyTorch dependency and use it for item-item k-NN #373

merged 21 commits into from
May 7, 2024

Conversation

mdekstrand
Copy link
Member

@mdekstrand mdekstrand commented May 6, 2024 •
edited
Loading

This makes three changes in support of #374:

@mdekstrand mdekstrand added components LensKit recommendation components dependencies Pull requests that update a dependency file labels May 6, 2024
@mdekstrand mdekstrand added this to the 2024.1 milestone May 6, 2024
@mdekstrand mdekstrand self-assigned this May 6, 2024
@mdekstrand mdekstrand mentioned this pull request May 6, 2024
Closed
@mdekstrand mdekstrand force-pushed the feature/torch-item-knn branch from 790ef3d to 56d7949 Compare May 6, 2024 23:23
@mdekstrand mdekstrand force-pushed the feature/torch-item-knn branch from 56d7949 to ab361c5 Compare May 6, 2024 23:47
@codecov Codecov
Copy link

codecov bot commented May 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.52434% with 52 lines in your changes are missing coverage. Please review.

Project coverage is 90.85%. Comparing base (c455d5b) to head (ffcf1df).

❗ Current head ffcf1df differs from pull request most recent head 1caf2dd. Consider uploading reports for the commit 1caf2dd to get more accurate results

Files Patch % Lines
lenskit/algorithms/item_knn.py 76.27% 51 Missing ⚠️
lenskit/data/matrix.py 98.03% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
- Coverage   91.01%   90.85%   -0.17%     
==========================================
  Files          40       40              
  Lines        3128     3138      +10     
==========================================
+ Hits         2847     2851       +4     
- Misses        281      287       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdekstrand mdekstrand merged commit 1caf2dd into lenskit:main May 7, 2024
18 checks passed
@mdekstrand mdekstrand deleted the feature/torch-item-knn branch May 7, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mdekstrand mdekstrand

Labels
components LensKit recommendation components dependencies Pull requests that update a dependency file
Projects
LensKit Overhaul
Status: Done
Milestone
2025.1
Development

Successfully merging this pull request may close these issues.

Use PyTorch to implement item-item k-NN Add PyTorch to LensKit dependencies
1 participant
@mdekstrand